VReplication: Support automatically replacing auto_inc cols with sequences #16860

mattlord · 2024-09-27T16:10:31Z

Description

Since #15679 we automatically strip any MySQL auto_increment clauses on tables that are being moved (using the MoveTables command) from an unsharded keyspace to a sharded one. And since #13656 we support initializing any sequences in the target keyspace on SwitchTraffic.

In this PR, we build upon both of those items of work to support automatically creating a Vitess Sequence for each if those tables that HAD an auto_increment clause if one does not already exist. This requires the use of two flags:

When creating the workflow, specify:
- That we want to replace any removed MySQL auto_increment clauses with vschema AutoIncrement definitions using --sharded-auto-increment-handling=replace
- An unsharded keyspace in --global-keyspace that we can then later use to create the sequence tables in if they don't already exist (they don't in the manual test below)
When switching traffic, specify the --initialize-target-sequences flag, which will create a missing sequence table when possible

Manual test

alias vtctldclient='command vtctldclient --server=localhost:15999'

./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql; ./201_customer_tablets.sh; ./202_move_tables.sh; ./203_switch_reads.sh; ./204_switch_writes.sh; ./205_clean_commerce.sh; ./301_customer_sharded.sh; ./302_new_shards.sh; ./303_reshard.sh; ./304_switch_reads.sh; ./305_switch_writes.sh; ./306_down_shard_0.sh; ./307_delete_shard_0.sh

vtctldclient ApplySchema --sql "alter table product drop primary key, add product_id int unsigned not null auto_increment primary key" commerce

vtctldclient ApplyVSchema --vschema='
{
  "sharded": true,
  "vindexes": {
    "hash": {
      "type": "hash"
    },
    "unicode_loose_xxhash": {
      "type": "unicode_loose_xxhash"
    }
  },
  "tables": {
    "corder": {
      "column_vindexes": [
        {
          "column": "customer_id",
          "name": "hash"
        }
      ],
      "auto_increment": {
        "column": "order_id",
        "sequence": "order_seq"
      }
    },
    "customer": {
      "column_vindexes": [
        {
          "column": "customer_id",
          "name": "hash"
        }
      ],
      "auto_increment": {
        "column": "customer_id",
        "sequence": "customer_seq"
      }
    },
    "product": {
      "column_vindexes": [
        {
          "column": "sku",
          "name": "unicode_loose_xxhash"
        }
      ]
    }
  }
}
' customer

sleep 5

vtctldclient MoveTables --workflow commerce2customer --target-keyspace customer create --source-keyspace commerce --tables product --sharded-auto-increment-handling=replace --global-keyspace commerce

vtctldclient GetVSchema customer --compact

mysql commerce -e "insert into product (sku, description, price) values ('SKU-1003', 'Mouse', 5)"

sleep 5

vtctldclient MoveTables --workflow commerce2customer --target-keyspace customer switchtraffic --initialize-target-sequences

vtctldclient GetVSchema customer --compact

mysql commerce -e "show tables"

mysql commerce -e "select * from product order by product_id"

mysql commerce -e "select * from product_seq"

mysql commerce -e "insert into product (sku, description, price) values ('SKU-1004', 'Table', 199), ('SKU-1005', 'Chair', 99)"

mysql commerce -e "select * from product order by product_id"

mysql commerce -e "select * from product_seq"

Results:

{
  "sharded": true,
  "vindexes": {
    "hash": {
      "type": "hash"
    }
  },
  "tables": {
    "corder": {
      "column_vindexes": [
        {
          "column": "customer_id",
          "name": "hash"
        }
      ],
      "auto_increment": {
        "column": "order_id",
        "sequence": "order_seq"
      }
    },
    "customer": {
      "column_vindexes": [
        {
          "column": "customer_id",
          "name": "hash"
        }
      ],
      "auto_increment": {
        "column": "customer_id",
        "sequence": "customer_seq"
      }
    },
    "product": {
      "column_vindexes": [
        {
          "column": "product_id",
          "name": "hash"
        }
      ],
      "auto_increment": {
        "column": "product_id",
        "sequence": "product_seq"
      }
    }
  }
}
+--------------------+
| Tables_in_commerce |
+--------------------+
| customer_seq       |
| order_seq          |
| product            |
| product_seq        |
+--------------------+
+----------+-------------+-------+------------+
+----------+-------------+-------+------------+
| sku      | description | price | product_id |
+----------+-------------+-------+------------+
| SKU-1001 | Monitor     |   100 |          1 |
| SKU-1002 | Keyboard    |    30 |          2 |
| SKU-1003 | Mouse       |     5 |          3 |
+----------+-------------+-------+------------+
+----+---------+-------+
| id | next_id | cache |
+----+---------+-------+
|  0 |       4 |  1000 |
+----+---------+-------+
+----------+-------------+-------+------------+
| sku      | description | price | product_id |
+----------+-------------+-------+------------+
| SKU-1001 | Monitor     |   100 |          1 |
| SKU-1002 | Keyboard    |    30 |          2 |
| SKU-1003 | Mouse       |     5 |          3 |
| SKU-1004 | Table       |   199 |          4 |
| SKU-1005 | Chair       |    99 |          5 |
+----------+-------------+-------+------------+
+----+---------+-------+
| id | next_id | cache |
+----+---------+-------+
|  0 |    1004 |  1000 |
+----+---------+-------+

The strip_sharded_auto_increment field was renamed to sharded_auto_increment_handling — which is upgrade/downgrade safe with protobufs as field indexes are used — and the type of the proto field was changed from bool to an enum/int32 to support the new REPLACE option. This is upgrade/downgrade safe because the wire format for bool is a varint with 0 being false and 1 being true — with the deserialization ending up 0 = false > 0 = true. To demonstrate:

git checkout vrepl_replace_auto_inc && make build 
cp bin/vtctldclient /tmp

git checkout main && make build
cd examples/local
./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql; ./201_customer_tablets.sh

❯ vtctldclient MoveTables --workflow commerce2customer --target-keyspace customer create --source-keyspace commerce --tables product --remove-sharded-auto-increment=REPLACE --global-keyspace commerce
E0930 17:51:16.473295   29269 main.go:56] invalid argument "REPLACE" for "--remove-sharded-auto-increment" flag: strconv.ParseBool: parsing "REPLACE": invalid syntax

❯ /tmp/vtctldclient --server=localhost:15999  MoveTables --workflow commerce2customer --target-keyspace customer create --source-keyspace commerce --tables product --sharded-auto-increment-handling=REPLACE --global-keyspace commerce
The following vreplication streams exist for workflow customer.commerce2customer:

id=1 on customer/zone1-200: Status: Copying. VStream has not started.

Traffic State: Reads Not Switched. Writes Not Switched

❯ command mysql -u root --socket ${VTDATAROOT}/vt_0000000$(vtctldclient GetTablets --keyspace customer --tablet-type primary --shard "0" | awk '{print $1}' | cut -d- -f2 | bc)/mysql.sock vt_customer -e "select * from _vt.vreplication\G"
*************************** 1. row ***************************
                   id: 1
             workflow: commerce2customer
               source: keyspace:"commerce" shard:"0" filter:{rules:{match:"product" filter:"select * from product"}}
                  pos: MySQL56/9fec34ea-7f75-11ef-8280-bf546605e365:1-45
             stop_pos: NULL
              max_tps: 0
  max_replication_lag: 0
                 cell: zone1
         tablet_types: replica,primary
         time_updated: 1727733136
transaction_timestamp: 0
                state: Running
              message:
              db_name: vt_customer
          rows_copied: 0
                 tags:
       time_heartbeat: 1727733136
        workflow_type: 1
       time_throttled: 0
  component_throttled:
     reason_throttled:
    workflow_sub_type: 0
 defer_secondary_keys: 0
              options: {"strip_sharded_auto_increment": true}

And using the manual test case from above but using binaries built on main with a vtctldclient binary from the PR branch:

...

❯ /tmp/vtctldclient --server :15999 MoveTables --workflow commerce2customer --target-keyspace customer create --source-keyspace commerce --tables product --sharded-auto-increment-handling=replace --global-keyspace commerce
The following vreplication streams exist for workflow customer.commerce2customer:

id=2 on customer/zone1-300: Status: Copying. VStream has not started.
id=2 on customer/zone1-401: Status: Copying. VStream has not started.

Traffic State: Reads Not Switched. Writes Not Switched

❯ mysql commerce/0 -e "show create table product\G"
*************************** 1. row ***************************
       Table: product
Create Table: CREATE TABLE `product` (
  `sku` varbinary(128) NOT NULL,
  `description` varbinary(128) DEFAULT NULL,
  `price` bigint DEFAULT NULL,
  `product_id` int unsigned NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`product_id`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci

❯ mysql customer/-80 -e "show create table product\G"
*************************** 1. row ***************************
       Table: product
Create Table: CREATE TABLE `product` (
  `sku` varbinary(128) NOT NULL,
  `description` varbinary(128) DEFAULT NULL,
  `price` bigint DEFAULT NULL,
  `product_id` int unsigned NOT NULL,
  PRIMARY KEY (`product_id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci

So we can see that the auto_increment clauses were still removed.

Related Issue(s)

Fixes: Feature Request: MoveTables support for auto replacing auto_inc cols with sequences #16864

Checklist

"Backport to:" labels have been added if this change should be back-ported to release branches
If this change is to be back-ported to previous releases, a justification is included in the PR description
Tests were added or are not required
Did the new or modified tests pass consistently locally and on CI?
Documentation: Add docs for MoveTables auto increment handling website#1859

vitess-bot · 2024-09-27T16:10:33Z

codecov · 2024-09-27T17:03:51Z

Codecov Report

Attention: Patch coverage is 68.27586% with 46 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (945124a) to head (1d8601a).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtctl/workflow/traffic_switcher.go	56.41%	34 Missing ⚠️
...ldclient/command/vreplication/movetables/create.go	0.00%	7 Missing ⚠️
go/vt/vtctl/workflow/server.go	81.81%	2 Missing ⚠️
go/vt/vtctl/workflow/utils.go	60.00%	2 Missing ⚠️
go/vt/vtctl/workflow/materializer.go	96.15%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #16860    +/-   ##
========================================
  Coverage   69.42%   69.43%            
========================================
  Files        1571     1571            
  Lines      203304   203433   +129     
========================================
+ Hits       141148   141249   +101     
- Misses      62156    62184    +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matt Lord <mattalord@gmail.com>

go/cmd/vtctldclient/command/vreplication/movetables/movetables.go

deepthi · 2024-10-02T16:20:54Z

proto/vtctldata.proto

-  bool strip_sharded_auto_increment = 2;
+  // keyspace and optionally replace them with vschema AutoIncrement
+  // definitions.
+  ShardedAutoIncrementHandling strip_sharded_auto_increment = 2;


We should rename this to sharded_auto_increment_handling or similar. Renaming proto fields does not break compatibility in anyway.

Btw, when did we add this field? If it was within v21, we are fine. otherwise we'd have to reserve this and add a new field because we are changing the type.

Good point on renaming. Will do. That field was added in v20.

then changing bool to enum is theoretically a breaking change. BUT, since this is between vtctldclient and vtctld, we can assume that their versions should match and not worry about reserving the field.

The potential problem with renaming the proto field is that the field name is used when marshalling/unmarshalling the field to protojson or prototext. So it would mean that we do not read the value properly for old/existing workflows ... which is fine because in the older versions any actions taken from that value are done when creating the workflow and the value is not needed/used after that.

I tried to address this here: 733198b

deepthi · 2024-10-02T16:21:28Z

proto/vtctldata.proto

@@ -209,16 +209,25 @@ message Shard {
  topodata.Shard shard = 3;
 }

+enum ShardedAutoIncrementHandling {
+  LEAVE = 0;


WDYT of calling this NONE instead of LEAVE? Meaning we do nothing.

I'm fine either way. If you prefer that then I'm fine changing it.

Let's change it then.

Now I remember that this is what I had started with, but you cannot:

vtctldata.proto:213:3: "NONE" is already defined in "vtctldata".

See: protocolbuffers/protobuf#5425

So we can leave it at LEAVE, or change it to e.g. NO_HANDLING etc.

It's fine, let's "leave" it.

deepthi · 2024-10-02T16:23:20Z

go/vt/vtctl/workflow/traffic_switcher_test.go

+		targetVSchema                  *vschema.Keyspace
+		options                        *vtctldatapb.WorkflowOptions
+		want                           map[string]*sequenceMetadata
+		expectSourceApplySchemaRequest *applySchemaRequestResponse


there seems to be a mismatch between the field name and type. Should the field name also be ...Response?

It gets a bit long, and this is test-only code where you can clearly see the type, but I can change it.

oh you mean if you call it ...RequestResponse? I think expectApplySchemaResponse is adequate.

I changed it here: 733198b

deepthi · 2024-10-02T16:29:16Z

go/cmd/vtctldclient/command/vreplication/common/utils.go

@@ -287,7 +287,7 @@ func AddCommonSwitchTrafficFlags(cmd *cobra.Command, initializeTargetSequences b
 	cmd.Flags().BoolVar(&SwitchTrafficOptions.DryRun, "dry-run", false, "Print the actions that would be taken and report any known errors that would have occurred.")
 	cmd.Flags().BoolVar(&SwitchTrafficOptions.Force, "force", false, "Force the traffic switch even if some potentially non-critical actions cannot be performed; for example the tablet refresh fails on some tablets in the keyspace. WARNING: this should be used with extreme caution and only in emergency situations!")
 	if initializeTargetSequences {
-		cmd.Flags().BoolVar(&SwitchTrafficOptions.InitializeTargetSequences, "initialize-target-sequences", false, "When moving tables from an unsharded keyspace to a sharded keyspace, initialize any sequences that are being used on the target when switching writes.")
+		cmd.Flags().BoolVar(&SwitchTrafficOptions.InitializeTargetSequences, "initialize-target-sequences", false, "When moving tables from an unsharded keyspace to a sharded keyspace, initialize any sequences that are being used on the target when switching writes. If the sequence table is not found AND the sequence table reference was fully qualified OR a value was specified for --global-keyspace, then we will attempt to create each sequence table in that keyspace if it doesn't exist.")


It's unclear exactly what the boolean logic here means to someone who doesn't already know it.
I'm reading it as

(IF the sequence table is not found) AND ((the sequence table reference was fully qualified) OR (a value was specified for --global-keyspace))

but it should be rewritten to avoid confusion.

I can think about how to make it more clear. It reads pretty clear to me but I'll think about it.

I tried to address this here: 733198b

The change is subtle, but I think it's quite clear.

deepthi · 2024-10-02T16:30:33Z

go/cmd/vtctldclient/command/vreplication/movetables/create.go

@@ -40,6 +40,8 @@ var (
 		NoRoutingRules      bool
 		AtomicCopy          bool
 		WorkflowOptions     vtctldatapb.WorkflowOptions
+		// This maps to a WorkflowOptions.StripShardedAutoIncrement ENUM value.
+		StripShardedAutoIncrementStr string


Along with the proto name change, we should change this name. It is confusing to call it Strip when it could be NONE/REMOVE/REPLACE.

There seems to be some nuance here that I missed during review. So maybe you just need to explain what I'm missing :)
Quoting Rohit:

Maybe consider naming the StripShardedAutoIncrement differently for the string and enum representations. Also adding a comment to note that the first one is from the CLI flags and second to set in the _vt.vreplication row.

OK. I'll rename it to ShardedAutoIncrementHandling[Str]

I tried to address this here: 733198b

go/cmd/vtctldclient/command/vreplication/movetables/create.go

Signed-off-by: Matt Lord <mattalord@gmail.com>

deepthi · 2024-10-02T17:59:27Z

We'll run the website docs update for the vtctld command reference once before release.

Signed-off-by: Matt Lord <mattalord@gmail.com>

deepthi · 2024-10-03T18:52:55Z

changelog/21.0/21.0.0/summary.md


-## <a id="major-changes"/>Major Changes
+## <a id="major-changes"/>Major Changes</a>


Was adding </a> to every section heading done by your editor? Seems unnecessary.

I did it as w/o it the content is messed up in some readers (the preview one I use). It’s proper to end it.

deepthi · 2024-10-03T18:54:06Z

changelog/21.0/21.0.0/summary.md

+
+### <a id="auto-replace-mysql-autoinc-with-seq"/>Automatically Replace MySQL auto_increment Clauses with Vitess Sequences</a>
+
+When migrating tables from an unsharded keyspace to a sharded one using the [VReplication `MoveTables` command](https://vitess.io/docs/reference/vreplication/movetables/), we now support


This is too verbose for a summary. Can you please condense it into a short paragraph? No need to give all the background, just describe the feature briefly.

In my mind if we add something to the summary we think it’s worth highlighting. At a minimum we should then describe what the thing is that we’re highlighting and explain why we think it’s worth highlighting. Which to me includes the context for what it is, what it is, why it’s important, when you'd use it, and how to use it. Two paragraphs is not a lot IMO and if you look at this and previous summary docs multiple paragraphs is quite common (just look at the one right above this). That being said, I will try and condense it and eliminate some content that isn’t strictly necessary for the stated objectives.

I created a docs PR for this: vitessio/website#1859

Once that's merged this can become a short paragraph that links to this for additional details: https://deploy-preview-1859--vitess.netlify.app/docs/21.0/reference/vreplication/movetables/#auto-increment-handling

Updated in 3ceb253 Thanks!

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Update reference docs for vitessio/vitess#16860 Signed-off-by: Matt Lord <mattalord@gmail.com> * Add new section to the movetables reference page Signed-off-by: Matt Lord <mattalord@gmail.com> * Add keyspace concept link Signed-off-by: Matt Lord <mattalord@gmail.com> * Changes from self review Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct keyspace concept link Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor tweak Signed-off-by: Matt Lord <mattalord@gmail.com> * Unify formatting Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication labels Sep 27, 2024

mattlord removed the NeedsBackportReason If backport labels have been applied to a PR, a justification is required label Sep 27, 2024

github-actions bot added this to the v21.0.0 milestone Sep 27, 2024

mattlord force-pushed the vrepl_replace_auto_inc branch 2 times, most recently from 82a1670 to eec4b9c Compare September 27, 2024 16:43

Support automatically replacing auto_increment columns with sequences

e6487dd

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Sep 27, 2024

Various improvements

33b4cc9

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vrepl_replace_auto_inc branch from eec4b9c to 33b4cc9 Compare September 29, 2024 19:09

Improve errors

e56dd5b

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vrepl_replace_auto_inc branch from 1c85d2a to e56dd5b Compare September 29, 2024 19:32

Add to flag handling test

1cb3de5

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vrepl_replace_auto_inc branch 2 times, most recently from f462d86 to 21b2871 Compare September 29, 2024 21:26

Add unit test

f5eb4e2

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vrepl_replace_auto_inc branch from 21b2871 to f5eb4e2 Compare September 29, 2024 21:28

mattlord changed the title ~~VReplication: Support automatically replacing auto_increment columns with sequences~~ VReplication: Support automatically replacing auto_inc cols with sequences Sep 29, 2024

mattlord force-pushed the vrepl_replace_auto_inc branch from 5f28cfa to ea0d3ad Compare September 30, 2024 04:52

Support creating missing sequence backing tables during init

b110120

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vrepl_replace_auto_inc branch from ea0d3ad to b110120 Compare September 30, 2024 05:16

mattlord added 2 commits September 30, 2024 11:07

Changes from self review

6fc7fdc

Signed-off-by: Matt Lord <mattalord@gmail.com>

Add unit test for auto table creation

e89bbf7

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vrepl_replace_auto_inc branch from 669a5f7 to e89bbf7 Compare September 30, 2024 16:27

deepthi reviewed Oct 2, 2024

View reviewed changes

mattlord added 2 commits October 2, 2024 13:28

Address review comments

733198b

Signed-off-by: Matt Lord <mattalord@gmail.com>

Correct comment

67c1ef1

Signed-off-by: Matt Lord <mattalord@gmail.com>

deepthi approved these changes Oct 2, 2024

View reviewed changes

deepthi removed the NeedsWebsiteDocsUpdate What it says label Oct 2, 2024

deepthi added the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Oct 3, 2024

mattlord added 2 commits October 3, 2024 13:32

Merge remote-tracking branch 'origin/main' into vrepl_replace_auto_inc

316a111

Signed-off-by: Matt Lord <mattalord@gmail.com>

Add section about the new feature to the release summary

a56010e

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Oct 3, 2024

mattlord added 2 commits October 3, 2024 14:21

Correct flag value

cd7eea1

Signed-off-by: Matt Lord <mattalord@gmail.com>

Add reference table linnk

14b6873

Signed-off-by: Matt Lord <mattalord@gmail.com>

deepthi reviewed Oct 3, 2024

View reviewed changes

mattlord added release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) NeedsWebsiteDocsUpdate What it says labels Oct 3, 2024

mattlord added a commit to vitessio/website that referenced this pull request Oct 3, 2024

Update reference docs for vitessio/vitess#16860

3cb012c

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord mentioned this pull request Oct 3, 2024

Add docs for MoveTables auto increment handling vitessio/website#1859

Merged

rohit-nayak-ps mentioned this pull request Oct 4, 2024

Vitess Release v21 Tracking Issue #16795

Closed

57 tasks

Update summary note

3ceb253

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord removed release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) NeedsWebsiteDocsUpdate What it says labels Oct 4, 2024

mattlord added 2 commits October 4, 2024 11:34

Merge remote-tracking branch 'origin/main' into vrepl_replace_auto_inc

2bb2a3a

Signed-off-by: Matt Lord <mattalord@gmail.com>

Merge remote-tracking branch 'origin/main' into vrepl_replace_auto_inc

1d8601a

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord merged commit 1e59408 into vitessio:main Oct 4, 2024
101 checks passed

mattlord deleted the vrepl_replace_auto_inc branch October 4, 2024 18:35

BrewTestBot mentioned this pull request Oct 29, 2024

vitess 21.0.0 Homebrew/homebrew-core#195900

Merged

notfelineit mentioned this pull request Nov 7, 2024

Feature Request: qualify generated sequence table name #17173

Closed

mattlord mentioned this pull request Nov 7, 2024

VReplication: Qualify and SQL escape tables in created AutoIncrement VSchema definitions #17174

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VReplication: Support automatically replacing auto_inc cols with sequences #16860

VReplication: Support automatically replacing auto_inc cols with sequences #16860

mattlord commented Sep 27, 2024 •

edited

Loading

vitess-bot bot commented Sep 27, 2024

codecov bot commented Sep 27, 2024 •

edited

Loading

deepthi Oct 2, 2024

deepthi Oct 2, 2024

mattlord Oct 2, 2024

deepthi Oct 2, 2024

mattlord Oct 2, 2024

mattlord Oct 2, 2024

deepthi Oct 2, 2024

mattlord Oct 2, 2024 •

edited

Loading

deepthi Oct 2, 2024

mattlord Oct 2, 2024

deepthi Oct 2, 2024

deepthi Oct 2, 2024

mattlord Oct 2, 2024 •

edited

Loading

deepthi Oct 2, 2024

mattlord Oct 2, 2024

deepthi Oct 2, 2024

mattlord Oct 2, 2024

mattlord Oct 2, 2024

deepthi Oct 2, 2024

deepthi Oct 2, 2024

mattlord Oct 2, 2024 •

edited

Loading

mattlord Oct 2, 2024

deepthi commented Oct 2, 2024

deepthi Oct 3, 2024 •

edited

Loading

mattlord Oct 3, 2024

deepthi Oct 3, 2024

mattlord Oct 3, 2024 •

edited

Loading

mattlord Oct 4, 2024

mattlord Oct 4, 2024 •

edited

Loading


		## <a id="major-changes"/>Major Changes
		## <a id="major-changes"/>Major Changes</a>


		### <a id="auto-replace-mysql-autoinc-with-seq"/>Automatically Replace MySQL auto_increment Clauses with Vitess Sequences</a>

		When migrating tables from an unsharded keyspace to a sharded one using the [VReplication `MoveTables` command](https://vitess.io/docs/reference/vreplication/movetables/), we now support

VReplication: Support automatically replacing auto_inc cols with sequences #16860

VReplication: Support automatically replacing auto_inc cols with sequences #16860

Conversation

mattlord commented Sep 27, 2024 • edited Loading

Description

Manual test

Related Issue(s)

Checklist

vitess-bot bot commented Sep 27, 2024

Review Checklist

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

codecov bot commented Sep 27, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattlord Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattlord Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattlord Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepthi commented Oct 2, 2024

deepthi Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattlord Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattlord Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

mattlord commented Sep 27, 2024 •

edited

Loading

codecov bot commented Sep 27, 2024 •

edited

Loading

mattlord Oct 2, 2024 •

edited

Loading

mattlord Oct 2, 2024 •

edited

Loading

mattlord Oct 2, 2024 •

edited

Loading

deepthi Oct 3, 2024 •

edited

Loading

mattlord Oct 3, 2024 •

edited

Loading

mattlord Oct 4, 2024 •

edited

Loading